Am 01.04.2011 17:03, schrieb Barry Warsaw:
I think there's no harm in build system or doc fixes that will have no effect on functionality.
I do believe that the build system changes can actually break things. The first version of your patch produced additional output on stderr, which may cause breakage on build infrastructures that filter the build output (and, say, suddenly start sending cron email messages, every fifteen minutes). Your current change creates the temp build directories if they aren't there. This may cause breakage on systems that create them themselves at some point, and then fail because the directories are already there. The change can also break build systems that patch setup.py, and now fail since the patch doesn't apply anymore. *Any* change to behavior can potentially break something. In a security-only release, the only acceptable tradeoff to this breakage is that a security concern is resolved in return for the breakage. Regards, Martin