On Sun, Jul 8, 2012 at 12:59 AM, Nick Coghlan email@example.com wrote:
On Sat, Jul 7, 2012 at 11:55 PM, Antoine Pitrou firstname.lastname@example.org wrote:
I think the isinstance() test was correct. If you have an object which duck-types IPNetwork, you probably want its __eq__ to be called, not yours.
This change was just to bring IPNetwork in line with the other types in the module and to stop it throwing TypeError itself, which meant the RHS was never even getting a chance to affect the result.
Hmm, I just noticed the __lt__ implementations still throw TypeError directly (at least in the IPNetwork case). Looks like some more cleanups are still needed in this area :P