On 03.07.2020 3:10, Łukasz Langa wrote:
On 2 Jul 2020, at 21:38, Chris Angelico email@example.com wrote:
Formal proposal: Either request a new commit message from the original author, or have someone rewrite it, and we go ahead and make the change.
This would be serious precedent to fiddling with publicly replicated repo history. This would require coordination with project admins as force-pushes are rightfully disabled for our repositories.
Commit messages aren't usually scrutinized to this extent. If you looked at the last 1000 commits in cpython, you'd find quite a few with messages that could be seriously improved. We don't though because commits are immutable. You can revert them but we never downright replace them with different ones. Otherwise what's the point in me signing release tags?
Per https://firstname.lastname@example.org/message/T7CM4AUJ..., "commits are immutable" is just one point of view, as valid as the other one, and leaving this commit as is would be much more harmful than an average poorly-worded one.
Per https://email@example.com/message/KQSHT5RZ..., we're talking about an infinitely less impactful peps repo (per https://firstname.lastname@example.org/message/64LIUO4C..., only 6 people in the entire world would be affected).
And, no-one suggested overwriting a Python release, comparing this to that is blowing it way out of proportion.
Is the commit message perfect? No. Is the intent explained better on the linked PR? Yes. Is the change itself good? Also yes.
Formal proposal: leave this alone.
Python-Dev mailing list -- email@example.com To unsubscribe send an email to firstname.lastname@example.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://email@example.com/message/RED5C5ML... Code of Conduct: http://python.org/psf/codeofconduct/ -- Regards, Ivan