As a non-committer, I want to make a plea for non-committer approval reviews, or at least that they have a place. When asked how outsiders can contribute I frequently see "review open PRs" as a suggested way of contributing to CPython. Not being able to approve PRs that are good would be a barrier to those contributions.

Furthermore, I am collaborating with a couple of core devs, it would make collaboration more difficult if I couldn't review their work and say that I thought the changes looked good.

I know "drive by approvals" are annoying but I think it is unfortunately part of open source projects.


On Sat, Jan 29, 2022, 5:51 PM Inada Naoki <songofacandy@gmail.com> wrote:
On Sun, Jan 30, 2022 at 10:39 AM Ethan Furman <ethan@stoneleaf.us> wrote:
>
>
>  > And lots of non-committer PR reviews that only approve.
>
> I have seen this.  Quite irritating.
>

We can prohibit approval from non core developers. Do we use this
setting already?
https://github.blog/2021-11-01-github-keeps-getting-better-for-open-source-maintainers/


--
Inada Naoki  <songofacandy@gmail.com>
_______________________________________________
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-leave@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/KHXSE2MSEC5JR2QB5F6HJUFYCC4SHGFF/
Code of Conduct: http://python.org/psf/codeofconduct/