[Python-Dev] Re: Handling cross-distro variations when running autoreconf?

----- Original Message -----

From: "Nick Coghlan" To: "python-dev" Sent: Sunday, December 8, 2019 2:58:24 PM Subject: [Python-Dev] Handling cross-distro variations when running autoreconf?

Hi folks,

While reviewing https://github.com/python/cpython/pull/17303/files, I noticed that the configure script update removed the options for `--runstatedir`. Those options appear to come from a Debian patch that other distros don't yet have: https://sources.debian.org/patches/autoconf/2.69-11/add-runstatedir.patch/

Since I use Fedora, running autoreconf locally on the review branch didn't add those options back, but did add in various macros related to Fedora's modular build system (we don't use those macros explicitly ourselves, but presumably some of the m4 macros we do use include them in their expansions when run on Fedora systems, so aclocal picked them up).

Does anyone have any recommendations for dealing with this? My current plan is to revert back to the configure script from master, run autoreconf, and then use `git add -p` to only add in the desired changes, leaving everything else as it was on master.

Cheers, Nick.

-- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/L3EBGBFE... Code of Conduct: http://python.org/psf/codeofconduct/

Yep I've seen many PR's having the same things, basically the runstatedir options just keep appearing and disappearing on the cpython repo. I think 'git add -p' is the most sensible option and maybe a warning on the dev guide to check the configure when running autoreconf. -- Regards, Charalampos Stratakis Software Engineer Python Maintenance Team, Red Hat