Oct. 6, 2011
8:47 p.m.
Amaury Forgeot d'Arc <amauryfa <at> gmail.com> writes:
I'd prefer it was written : if (PyUnicode_READY(*filename) < 0) because "< 0" clearly indicates an error condition.
Why not just have it return 0 on error? This would be more consistent with API functions that return "false" values like NULL and would just be if (!PyUnicode_READY(s)) return NULL; in code. Regards, Benjamin