12 Feb
2020
12 Feb
'20
4:40 a.m.
On Tue, Feb 11, 2020 at 9:59 PM Guido van Rossum <guido@python.org> wrote:
The Pull Request title is "Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method", it looks relatively straightforward and thorough.
I've submitted a review; the actual code change is very simple and straightforward, but it would be good for someone with more experience with `importlib` (specifically setting up or mocking out a custom `__loader__.get_data`) to take a look at the tests and make a better suggestion than mine about how to make sure we're cleaning up properly. -- Zach