Benjamin Peterson wrote:
It looks like you need to add some tests for the bugs you fixed to test_mimetypes. While you're at it, you could improve that test generally, since it's not exactly extensive.
Okay, I'll try to do this sometime in the next few days, if I get the chance.
Then, you might garner some more reviews by putting your patch up on Rietveld; it makes reviewing much painful.
Okay, now that svn.python.org is back up, here's a Rietveld link: http://codereview.appspot.com/104091/show Cheers, Jacob Rus