19 May
2018
19 May
'18
1:29 p.m.
On 17 May 2018 at 06:34, Jeroen Demeyer
On 2018-05-16 17:31, Petr Viktorin wrote:
The larger a change is, the harder it is to understand
I already disagree here...
I'm afraid that you are still confusing the largeness of the *change* with the complexity of the *result* after the change was implemented.
That's not how code reviews work, as their complexity is governed by the number of lines changed (added/removed/modified), not just the number of lines that are left at the end. That said, "deletes more lines than it adds" is typically a point strongly in favour of a particular change. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia