Re: [Python-Dev] a bunch of Patch reviews

If someone could take a look at: [ 1069624 ] incomplete support for AF_PACKET in socketmodule.c I have to ship my own patched copy of the socket module because of this... :| On Sun, 2005-01-16 at 17:08 +0100, Irmen de Jong wrote:

Hello I've looked at one bug and a bunch of patches and added a comment to them:

(bug) [ 1102649 ] pickle files should be opened in binary mode Added a comment about a possible different solution

[ 946207 ] Non-blocking Socket Server Useless, what are the mixins for? Recommend close

[ 756021 ] Allow socket.inet_aton('255.255.255.255') on Windows Looks good but added suggestion about when to test for special case

[ 740827 ] add urldecode() method to urllib I think it's better to group these things into urlparse

[ 579435 ] Shadow Password Support Module Would be nice to have, I recently just couldn't do the user authentication that I wanted: based on the users' unix passwords

[ 1093468 ] socket leak in SocketServer Trivial and looks harmless, but don't the sockets get garbage collected once the request is done?

[ 1049151 ] adding bool support to xdrlib.py Simple patch and 2.4 is out now, so...

It would be nice if somebody could have a look at my own patches or help me a bit with them:

[ 1102879 ] Fix for 926423: socket timeouts + Ctrl-C don't play nice [ 1103213 ] Adding the missing socket.recvall() method [ 1103350 ] send/recv SEGMENT_SIZE should be used more in socketmodule [ 1062014 ] fix for 764437 AF_UNIX socket special linux socket names [ 1062060 ] fix for 1016880 urllib.urlretrieve silently truncates dwnld

Some of them come from the last Python Bug Day, see http://www.python.org/moin/PythonBugDayStatus

Thank you !

Regards,

--Irmen de Jong _______________________________________________ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/gjc%40inescporto.pt -- Gustavo J. A. M. Carneiro The universe is always one step beyond logic.