Thank you, thank you! Hopefully we can pull this one over the finish line, and it won't have to linger for another decade. :-)
On Tue, Feb 11, 2020 at 8:42 PM Zachary Ware email@example.com wrote:
On Tue, Feb 11, 2020 at 9:59 PM Guido van Rossum firstname.lastname@example.org wrote:
The Pull Request title is "Fix newline conversion when doctest.testfile
loads from a package whose loader has a get_data method", it looks relatively straightforward and thorough.
I've submitted a review; the actual code change is very simple and straightforward, but it would be good for someone with more experience with `importlib` (specifically setting up or mocking out a custom `__loader__.get_data`) to take a look at the tests and make a better suggestion than mine about how to make sure we're cleaning up properly.
-- Zach _______________________________________________ Python-Dev mailing list -- email@example.com To unsubscribe send an email to firstname.lastname@example.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://email@example.com/message/DSKFDCYG... Code of Conduct: http://python.org/psf/codeofconduct/