On Tue, Feb 11, 2020 at 9:59 PM Guido van Rossum <guido@python.org> wrote:
> The Pull Request title is "Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method", it looks relatively straightforward and thorough.

I've submitted a review; the actual code change is very simple and
straightforward, but it would be good for someone with more experience
with `importlib` (specifically setting up or mocking out a custom
`__loader__.get_data`) to take a look at the tests and make a better
suggestion than mine about how to make sure we're cleaning up
properly.

--
Zach
_______________________________________________
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-leave@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/DSKFDCYGLAK32FQZL7JARMJUDQPJOG2V/
Code of Conduct: http://python.org/psf/codeofconduct/