Thank you, thank you! Hopefully we can pull this one over the finish line, and it won't have to linger for another decade. :-)

On Tue, Feb 11, 2020 at 8:42 PM Zachary Ware <> wrote:
On Tue, Feb 11, 2020 at 9:59 PM Guido van Rossum <> wrote:
> The Pull Request title is "Fix newline conversion when doctest.testfile loads from a package whose loader has a get_data method", it looks relatively straightforward and thorough.

I've submitted a review; the actual code change is very simple and
straightforward, but it would be good for someone with more experience
with `importlib` (specifically setting up or mocking out a custom
`__loader__.get_data`) to take a look at the tests and make a better
suggestion than mine about how to make sure we're cleaning up

Python-Dev mailing list --
To unsubscribe send an email to
Message archived at
Code of Conduct:

--Guido van Rossum (
Pronouns: he/him (why is my pronoun here?)