_sre.c Log Message: Removed unreachable return to silence SGI compiler.
! /* shouldn't end up here */ ! return SRE_ERROR_ILLEGAL; }
--- 1141,1145 ---- }
! /* can't end up here */ }
[Fredrik Lundh]
I hate stuff like this: that line was there to make sure *I* don't mess up when developing SRE, not to deal with potentially broken compilers or misfired electrons.
isn't there any way to tell the SGI compiler to stop whining about this?
I've had better luck x-platform with, e.g., assert(!"can't get here"); /* !string is always false */ In non-debug builds, it vanishes so there's nothing for the compiler to gripe about; while in debug builds most compilers don't do enough flow analysis to realize there *is* something to gripe about. Overall, it would be more useful if SGI compilers in particular produced: C00666: Warning: -O may produce buggy code. after every executable line <wink>.