> But cases not supported before 3.7 (like List[int]) now produce fragile pickles.

List[int] pickled in 3.7 can't be un-pickled in 3.6, but I wouldn't worry too much about this because it never worked in 3.6.

I remember you proposed using __getitem__ in __reduce__, but I am not sure it is a better way, although it will fix the above problem.

I don't think this one is a blocker and we can move this discussion back to b.p.o., unless you have some particular concerns.

The AST one however looks more serious.

Ivan

On 24 May 2018 at 12:26, Serhiy Storchaka <storchaka@gmail.com> wrote:

24.05.18 19:02, Ned Deily пише:

On May 24, 2018, at 11:35, Serhiy Storchaka <storchaka@gmail.com> wrote:

I have doubts about two issues. I feel the responsibility for them because I had the opportunity to solve them before, but I lost it.

[...]

Serhiy, what are the bugs.python.org issue numbers for these? Are they marked as "release blocker"?

For docstring in AST: https://bugs.python.org/issue32911

Inada's patch looked complex (actually it mostly restored the code before his previous change). We didn't know about IPython and we decided that it is not worth to change this code at this stage (after beta2). And definitely it will be later to do this after rc1.

For pickling of typing types: https://bugs.python.org/issue32873

Ivan fixed cases supported before 3.7. They now are backward and forward compatible. But cases not supported before 3.7 (like List[int]) now produce fragile pickles.

_______________________________________________
python-committers mailing list
python-committers@python.org
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/