On Sat, 18 Dec 2004, Tim Peters wrote:
[Raymond, says test_glob and test_urllib fail on WinME now]
[Andrew MacIntyre]
I don't see any possible way for those checkins to affect any platform other than OS/2.
2 of the files are platform specific files (PC/os2emx/getpath.c, PC/os2vacpp/getpath.c), and the checkin to Modules/posixmodule.c is contained within a platform specific #if/#endif:
[Brett]
Perhaps, but if you look at line 3299 you will notice that a comment is started but not closed off before the next comment on line 3304. How is that comment supposed to be closed off?
That's obviously a bug, and was introduced by the patch. Andrew wanted
/* setup the pipe */
not
/* setup the pipe
Fair cop guv. Long exposure to a language with comments of the latter form has been a PITA at times. :-(
But we don't get there unless PYOS_OS2 and PYCC_VACPP are defined, so that can't explain Raymond's problem.
FWIW, the tests at issue pass on WinXP for me today w/ current CVS.
Good, though Raymond's report appeared to be focussed on the 2.3 branch. ------------------------------------------------------------------------- Andrew I MacIntyre "These thoughts are mine alone..." E-mail: andymac@bullseye.apana.org.au (pref) | Snail: PO Box 370 andymac@pcug.org.au (alt) | Belconnen ACT 2616 Web: http://www.andymac.org/ | Australia