Barry Scott wrote:
On 12 Apr 2020, at 21:49, Eric V. Smith eric@trueblade.com wrote: On 4/12/2020 4:08 PM, Barry Scott wrote: On 11 Apr 2020, at 16:28, Barry Scott <barry@barrys-emacs.org mailto:barry@barrys-emacs.org> wrote: modulefinder.py does not open source files in "rb" which prevents compile() from applying the encoding rules. snip I have created the bpo, the pr and have the checks passing except that I need a NEWS.d entry to make bedevere/news happy. I see the files have a special filename is that from an automatic process of a tool I need to run? Barry The tool is blurb (or the online blurb-it): https://devguide.python.org/committing/#what-s-new-and-news-entries https://devguide.python.org/committing/#what-s-new-and-news-entries I was reading this https://devguide.python.org/#contributing https://devguide.python.org/#contributing that does not mention blurb. I would not have though to look in the section on Accepting Pull Requests, as that not what I'm doing.
It's also available through the "Details" link of the failing status check on the PR. -Brett
Barry
Eric