On 05/11/2020 11:48 PM, Brandt Bucher wrote:
On 05/10/2020 14:39, Ethan Furman wrote:
On 05/10/2020 09:04 PM, Brandt Bucher wrote:
the author has counted dozens of other call sites in Python's standard library and tooling where it would be appropriate to enable this new feature immediately.
References, please.
Here are two dozens:
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a... - https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a... - https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
These are all after a function that ensures the iterables are the same length -- hardly seems a good idea to slow them down with an extra check for each digit.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
This one already has a check.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a... - https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Reasonable.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Already has a check.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Reasonable.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a... - https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Mismatch cannot happen.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Unsure if mismatch can happen.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a... - https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Mismatch cannot happen.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a... - https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Reasonable.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Wow -- I don't even know how to parse that!
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Maybe.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a... - https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Definitely.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Mismatch cannot happen.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a... - https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Reasonable.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Mismatch cannot happen.
- https://github.com/python/cpython/blob/27c0d9b54abaa4112d5a317b8aa78b39ad60a...
Mismatch cannot happen. So half of your examples are actually counter-examples. Did you vet them, or just pick matches against `zip(` ? Also, if a flag is used, won't that slow down every call to zip even when the flag is False? I know in many cases it probably won't matter, but I can see where it could in _pydecimal. -- ~Ethan~