On Mon, 28 Feb 2000, Greg Stein wrote:
I didn't have the heart to keep pestering Moshe, so I delayed a bit on the latest round (and then left town for a few days). As a result, I didn't get a chance to comment on this last patch.
I can't do anything about you leaving town, but I do hope you're not feeling you're pestering me... I *do* want comments: much better then bugs creeping into Python.
"Standard Guido Formatting" requires a space between the "if" and the "(". if, for, while, etc are not functions... they are language constructs.
I won't argue formatting style, but it's simply hard to change habits. (My company keeps bugging me about that too, but I simply have trouble with the space bar<wink>)
PyObject_Cmp() does *not* guarantee a value for cmp_res if it returns -1. Therefore, it is possible for cmp_res to be zero despite an error being returned from PyObject_Cmp. Thus, you get a false-positive hit.
Oops.
I'll resynch with CVS and correct the bug.
--
Moshe Zadka