What do you think about an environment variable?

    USE_VENV=false make html

Maybe we can use a variable with a more explicit name so people can keep it in their environments if they wish?

On Fri, Aug 6, 2021 at 7:19 AM Miro Hrončok <mhroncok@redhat.com> wrote:
On 06. 08. 21 12:21, Łukasz Langa wrote:
>
>> On 4 Aug 2021, at 11:48, Miro Hrončok <mhroncok@redhat.com> wrote:
>>
>> On 04. 08. 21 11:28, Petr Viktorin wrote:
>>> Hi,
>>> A recent change "make html" in the Doc directory create a venv if one wasn't there before. If you don't want to download sphinx and other dependencies from PyPI, you'll need to adjust your workflow.
>>> If you already have all the dependencies, the following command (in the CPython directory, not Doc) will build docs for you:
>>>       sphinx-build Doc Doc/build/
>>> The issue that added this is: https://bugs.python.org/issue44756
>>
>> For what it's worth, I think that:
>>
>> - changes in the workflow should be discussed first
>> - changes like this should not happen this late in the release cycle
>> - a documented/supported way to build the docs with make without venv should
>>    exist (currently, running `mkdir venv` before `make ...` kinda works)
>
> Sorry for the disruption, I approved the change. I didn't realize skipping the `venv` altogether was a viable build option and I've been making releases with docs for over two years now. For me this change was mostly a matter of convenience.
>
> If the current state is undesirable for downstream distributors, I can revert `make build` being explicitly dependent on `make venv`.

The current state is OK-ish but fragile. There is a way to skip the venv
creation by creating an empty venv directory. However, it is undocumented and
implementation-dependent (read: it is a hack). If we have a supported way to do
this, I wouldn't might the default changed (although, honestly I don't think
this should have been backported to 3.9 at this point).

> Regardless of that, for future build-related changes I'll make sure to loop more people in.

Thanks.

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok

_______________________________________________
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-leave@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/CTVVAVYOHQKNB4S36G36YP3SFXKBKIQE/
Code of Conduct: http://python.org/psf/codeofconduct/