Congrats, I've accepted the PEP. Nice work! Please work with the reviewers on the issue on the code.
(Steven or Oscar, if either of you could work Oscar's list of resolved issues into a patch for the PEP I'll happily update it, just mail it to email@example.com.)
On Mon, Sep 16, 2013 at 5:06 PM, Guido van Rossum firstname.lastname@example.org wrote:
On Mon, Sep 16, 2013 at 4:59 PM, Steven D'Aprano email@example.com:
On Mon, Sep 16, 2013 at 08:42:12AM -0700, Guido van Rossum wrote:
I'm ready to accept this PEP. Because I haven't read this entire thread (and 60 messages about random diversions is really too much to try and catch up on) I'll give people 24 hours to remind me of outstanding rejections.
I also haven't reviewed the code in any detail, but I believe the code review is going well, so I'm not concerned that the PEP would have to revised based on that alone.
There are a couple of outstanding issues that I am aware of, but I don't believe that either of these affect acceptance/rejection of the PEP. Please correct me if I am wrong.
- Implementation details of the statistics.sum function. Oscar is
giving me a lot of very valuable assistance speeding up the implementation of sum.
- The current implementation has extensive docstrings, but will also
need a separate statistics.rst file.
I don't recall any other outstanding issues, if I have forgotten any, please remind me.
Those certainly don't stand in the way of the PEP's acceptance (but they do block the commit of the code :-).
The issues that Oscar listed also all seem resolved (though they would make a nice addition to the "Discussion" section in the PEP).
-- --Guido van Rossum (python.org/~guido)