On 2020-01-27 21:42, Skip Montanaro wrote:
(Apologies. Not sure where to ask this, and I'm not much of a C++ programmer. Maybe I should have just added a comment to the still-open issue.)
I just noticed that Nick migrated the guts of Include/frameobject.h to include/cpython/frameobject.h. It's not clear to me that the latter should be #include'd directly from anywhere other than Include/frameobject.h. If that's the case, does the extern "C" stuff still need to be replicated in the lower level file? Won't the scope of the extern "C" block in Include/frameobject.h be active at the lower level?
Whatever the correct answer is, I suspect the same constraints should apply to all Include/cpython/*.h files.
You're correct: - The #ifndef/#error make a clear point that a include/cpython/*.h file is only to be included as part of its include/*.h - The inner extern "C" block overrides the outer one. If they're the same, it's useless.
But I'd call it a minor issue – a style issue, even. Probably not worth worrying about.