Martin v. Löwis schrieb:
Since I will probably add some documentation, and since this documentation will probably benefit from some reviews, what would be the best process ?
1/ commit the changeset and ask for a post-review by Georg (or others) 2/ hold the changeset in a diff for a pre-review ?
If you are confident that the documentation actually builds, feel free to commit it without pre-review. I recommend that you build the documentation at least once; I personally often commit documentation patches without testing first that they build when I'm confident about the markup I use.
FWIW, I review most doc patches as they come into the commits mailing list.
Also, since the docs are built regularly, and problems are usually fixed very fast, I don't want anybody to hold back a patch because of docs only.
1/ is better for the flow, but the quality of the doc might suffer from it if Georg (or others) doesn't have time to review it
This is of little concern. As long as the documentation continues to build (into html), nearly all documentation changes are improvements.
-- Thus spake the Lord: Thou shalt indent with four spaces. No more, no less. Four shall be the number of spaces thou shalt indent, and the number of thy indenting shall be four. Eight shalt thou not indent, nor either indent thou two, excepting that thou then proceed to four. Tabs are right out.