This will make review turnout quicker, since I can potentially review and
view the output from anywhere (phone while on a beach) instead of waiting
until I'm back home, open a computer, and then verify the output myself.
On Sun, Nov 4, 2018, 7:56 AM Steven D'Aprano On Sun, Nov 04, 2018 at 04:12:39PM +0100, Stephane Wirtel wrote: My workflow is the following steps: git wpr XYZ
cd ../cpython-XYZ
./configure --prefix=$PWD-build --with-pydebug --silent
make -j 4 -s
make PYTHON=../python -C Doc/ venv
make -C Doc/ check suspicious html serve and run the browser on http://localhost:8000/ and check the result. 1. Because I am a dev I can do it easily
2. If you are not a dev, you have to learn a new step (download sources,
compile sources, compile doc and check the result) If I am making doc patches, shouldn't I be doing that *before* I
submit the PR? How else will I know that my changes haven't broken the
docs? So surely I need to learn those steps regardless? (Not a rhetorical question.) I think this feature would be really useful for the contributors, the
reviewers and you, the core-dev. Sure. But the usefulness has to be weighed against the extra complexity,
the extra "one more thing that can break and needs to be maintained",
and the risk of abuse. I have no opinion on whether the pluses outweigh the minuses. --
Steve
_______________________________________________
Python-Dev mailing list
Python-Dev@python.org
https://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
https://mail.python.org/mailman/options/python-dev/mariatta%40python.org