On Sun, Jul 25, 2010 at 8:24 PM, Terry Reedy <tjreedy@udel.edu> wrote:
Is there any way a 'view' button could be added, along with the current edit and remove buttons, to produce the same web page and make it easier to review patches *before* commitment?
One thing that patch submitters can do already is to make sure that their patches are recognized as text/plain by the tracker. This can be achieved using standard extensions such as .patch, .diff, or .txt and avoiding non-satndard ones such as .patch2. Note that if you accidentally uploaded a text file with a wrong extension, you can go to the edit page and change the file name and/or content type. I think the tracker may become a little more proactive in enforcing plain text attachments by rejecting unrecognized extensions or warning users about them. On a similar note, I wonder if tracker should simply reject binary attachments with a possible exception of well formed UTF-8 text.