Nikita found a very real (and slightly embarrassing!) bug in a patch I wrote for the enum module a few months back, due to his efforts to improve test coverage. And there is an entire section of the DevGuide devoted to "Improving test coverage", stating that PRs such as the ones Nikita has been filing are valuable.
I have seen multiple PRs by other authors closed or criticised because they tried to change things in too many modules at once, or make "broad and sweeping" changes. Nikita, however, has always taken care to make his PRs easy to review, by keeping them small and focused.
His mentor has already stated that he specifically asked Nikita to cc him in whenever he filed PRs (and I certainly didn't get a "bad impression about his intentions" from the fact he was cc'ing in his mentor, which seems like a very reasonable thing for a new member of the triage team to do).
I'm only a triager (like Nikita), but I really don't see any problem here, personally.
Best wishes,
Alex
-------- Original message --------
From: Nikita Sobolev <mail@sobolevn.me>
Date: 01/02/2022 04:14 (GMT+00:00)
To: python-dev@python.org
Subject: [Python-Dev] Re: Increase of Spammy PRs and PR reviews
Link: https://github.com/python/cpython/pulls/sobolevn
First of all, Lrupert, sorry for all the noise and inconvenience I caused to you personally and to other community members! This totally was **not** my intention.
You could have reached out to me earlier via email or directly in some PR to share your concerns, maybe we could have this whole situation avoided.
Secondly, thanks for letting me know about how others might feel about my work. Feedback is always important. I hope I can learn a lot from this case.
But, I can tell you honestly that I've never been to a situation like this before and I don't know exactly how to handle it and what to improve in this specific case.
Third, I agree that almost all my PRs were about some trivial things. Mostly because I was reading through typeshed code (which requires looking through multiple CPython modules at a very high level) and test code for these modules where I've spotted quite a lot of details to fix.
I cannot obviously judge the quality of my work (except for being ok-ish), so I will leave this part out of scope. The only thing I can say here is that it's a bit sad thread to read on python-dev mailing list, but I will keep my optimism for the future :)
So, to sum things up:
- I am open to any feedback: if others also think that my work does not bring any value - this is fine! I can totally improve or work on something simpler / some other project. Anyone interested can write me a direct email: mail@sobolevn.me
- I am sorry for causing this thread. It is far from being a pleasant or technical read
Best Regards,
Nikita Sobolev
https://github.com/sobolevn
_______________________________________________
Python-Dev mailing list -- python-dev@python.org
To unsubscribe send an email to python-dev-leave@python.org
https://mail.python.org/mailman3/lists/python-dev.python.org/
Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/LF7V3ZASXK6DGD5MBBXP3YKHGOLW36D5/
Code of Conduct: http://python.org/psf/codeofconduct/