June 30, 2013
4:51 a.m.
Am 29.06.2013 21:29, schrieb R. David Murray:
I don't know if this is the commit at fault or not, but we are seeing segfaults in test_xml_etree on the buildbots now.
Yeah, it's my fault. Thanks!
u = PyUnicode_Decode((char*) template_buffer, 256, name, "replace"); - if (u == NULL || PyUnicode_READY(u))wr + Py_DECREF(u); return XML_STATUS_ERROR; + }
Py_DECREF() is wrong as u can be NULL. I have changed the code to use Py_XDECREF().