Re: [Python-Dev] cpython: Issue #15022: Add pickle and comparison support to types.SimpleNamespace.

On Sun, Feb 17, 2013 at 9:49 PM, Antoine Pitrou wrote:

On Sat, 16 Feb 2013 18:20:14 -0700 Eric Snow wrote:

...

On Sat, Feb 16, 2013 at 5:02 PM, Eric Snow wrote:

...

On Sat, Feb 16, 2013 at 4:45 PM, Antoine Pitrou wrote:

...

I think you should test with all pickle protocols.

I'll do that.

Out of curiousity, how critical is it to support protocols 0 and 1? I've made sure SimpleNamespace does, but it made me wonder what the use case is for the older protocols.

Not critical at all. It's just nice to have for consistency, but it shouldn't stop you if it's too difficult to implement.

Although in such cases, we probably want to test we generate a reasonable error message for the unsupported protocols, rather than silently writing junk to the pickle. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia