On Tue, May 12, 2015 at 3:09 PM Terry Reedy <tjreedy@udel.edu> wrote:
Gmail dumps patch review email in my junk box. The problem seems to be
the spoofed From: header.

Received: from psf.upfronthosting.co.za ([2a01:4f8:131:2480::3])
         by mx.google.com with ESMTP id
m1si26039166wjy.52.2015.05.12.00.20.38
         for <tjreedy@udel.edu>;
         Tue, 12 May 2015 00:20:38 -0700 (PDT)
Received-SPF: softfail (google.com: domain of transitioning
storchaka@gmail.com does not designate 2a01:4f8:131:2480::3 as permitted
sender) client-ip=2a01:4f8:131:2480::3;

Tracker reviews are the only false positives in my junk list. Otherwise,
I might stop reviewing. Verizon does not even deliver mail that fails
its junk test, so I would not be surprised if there are people who
simply do not get emailed reviews.

Tracker posts are sent from Person Name <report@bugs.python.org>
Perhaps reviews could come 'from' Person Name <review@bugs.python.org>

Even direct tracker posts just get a neutral score.
Received-SPF: neutral (google.com: 2a01:4f8:131:2480::3 is neither
permitted nor denied by best guess record for domain of
roundup-admin@psf.upfronthosting.co.za) client-ip=2a01:4f8:131:2480::3;

SPF is Sender Policy Framework
https://en.wikipedia.org/wiki/Sender_Policy_Framework

Checkins mail, for instance, gets an SPF 'pass' because python.org
designates mail.python.org as a permitted sender.

--
Terry Jan Reedy

FWIW while the email signing issue might be interesting to fix...  I really wish code reviews weren't emailed separately, I'd like to see them simply appended to the related issue as a block comment on the issue. Then all email notification would be handled by the bug tracker itself (which happens to already work).  It keeps related conversation in a single place which will continue to persist even if we switch review tools in the future.

I believe you can get this to happen today in a review if you add the report@bugs.python.org email address to the code review as the issueXXXXX in the subject line will make the tracker turn it into a bug comment.  If so, having that be the default cc for all reviews created would be a great feature (and modify it not to send mail to anyone else).

My 2 cents.  (literally; as I'm only suggesting, not implementing)

-gps