Thank you David, I didn't think of the issue tracker. I have just done it.
Guido
----- Ursprüngliche Message ----- Von: R. David Murray rdmurray@bitdance.com An: Developer Developer just_another_developer@yahoo.de CC: "python-dev@python.org" python-dev@python.org Gesendet: 16:59 Montag, 11.Februar 2013 Betreff: Re: [Python-Dev] Question regarding: Lib/_markupbase.py
If these don't get reported as tracker issues they will probably get lost.
--David
On Mon, 11 Feb 2013 14:47:00 +0000, Developer Developer just_another_developer@yahoo.de wrote:
Same thing in the function: "_parse_doctype_attlist":
if ")" in rawdata[j:]: j = rawdata.find(")", j) + 1 else: return -1
I would change it to: pos = rawdata.find(")", j) if pos != -1: j = pos + 1 else: return -1
Best regards, Guido
----- Ursprüngliche Message ----- Von: Fred Drake fred@fdrake.net An: Developer Developer just_another_developer@yahoo.de CC: "python-dev@python.org" python-dev@python.org Gesendet: 15:10 Montag, 11.Februar 2013 Betreff: Re: [Python-Dev] Question regarding: Lib/_markupbase.py
On Mon, Feb 11, 2013 at 7:16 AM, Developer Developer just_another_developer@yahoo.de wrote:
Wouldn't it be better to do the following?
...
Otherwise I think we are scanning rawdata[j:] twice.
Yes, that would be better, and avoids a string object creation as well.
-Fred
-- Fred L. Drake, Jr. <fred at fdrake.net> "A storm broke loose in my mind." --Albert Einstein
Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/rdmurray%40bitdance.com