On Mon, Nov 25, 2013 at 12:46 AM, Nick Coghlan <ncoghlan@gmail.com> wrote:


On 25 Nov 2013 14:46, "gregory.p.smith" <python-checkins@python.org> wrote:
>
> http://hg.python.org/cpython/rev/cac7319c5972
> changeset:   87537:cac7319c5972
> branch:      2.7
> parent:      87534:3981e57a7bdc
> user:        Gregory P. Smith <greg@krypto.org>
> date:        Mon Nov 25 04:45:27 2013 +0000
> summary:
>   Fix test_fcntl to run properly on systems that do not support the flags
> used in the "does the value get passed in properly" test.
>
> files:
>   Lib/test/test_fcntl.py |  3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
>
> diff --git a/Lib/test/test_fcntl.py b/Lib/test/test_fcntl.py
> --- a/Lib/test/test_fcntl.py
> +++ b/Lib/test/test_fcntl.py
> @@ -113,7 +113,10 @@
>              self.skipTest("F_NOTIFY or DN_MULTISHOT unavailable")
>          fd = os.open(os.path.dirname(os.path.abspath(TESTFN)), os.O_RDONLY)
>          try:
> +            # This will raise OverflowError if issue1309352 is present.
>              fcntl.fcntl(fd, cmd, flags)
> +        except IOError:
> +            pass  # Running on a system that doesn't support these flags.
>          finally:
>              os.close(fd)

Raising a skip is generally preferred to marking a test that can't be executed as passing.

For this test this is still a pass because no OverflowError was raised.