Does anyone use CALL_PROFILE special build?
Hi, I proposed a patch to drop the CALL_PROFILE special build to simplify Python/ceval.c: http://bugs.python.org/issue28799 I modified ceval.c for fast calls in Python 3.6, and I'm not sure that the feature still works correctly. The feature is not well documented and not tested at all. For fast calls, I moved some code, so it's more complex to update call statistics since statistics are implemented in ceval.c. I would like to completely remove the feature to be able to implement further optimizations. Victor
On Nov 25, 2016, at 1:28 AM, Victor Stinner <victor.stinner@gmail.com> wrote:
I would like to completely remove the feature to be able to implement further optimizations.
This seems reasonable to me. I've never used or needed this special build; StackOverflow has no mention of it; and a Google search comes up nearly empty. That said, it might be worthwhile to check with Jeremy to get his thoughts before removing his code. Raymond
I don't think there's any need to keep this feature. I hope we have better ways to profile function and method calls now than we did when this code was submitted. Jeremy On Sat, Nov 26, 2016 at 3:34 AM Raymond Hettinger < raymond.hettinger@gmail.com> wrote:
On Nov 25, 2016, at 1:28 AM, Victor Stinner <victor.stinner@gmail.com> wrote:
I would like to completely remove the feature to be able to implement further optimizations.
This seems reasonable to me. I've never used or needed this special build; StackOverflow has no mention of it; and a Google search comes up nearly empty. That said, it might be worthwhile to check with Jeremy to get his thoughts before removing his code.
Raymond
Ok, thanks. I pushed my patch. Victor 2016-11-27 16:37 GMT+01:00 Jeremy Hylton <jeremy@alum.mit.edu>:
I don't think there's any need to keep this feature. I hope we have better ways to profile function and method calls now than we did when this code was submitted.
Jeremy
On Sat, Nov 26, 2016 at 3:34 AM Raymond Hettinger <raymond.hettinger@gmail.com> wrote:
On Nov 25, 2016, at 1:28 AM, Victor Stinner <victor.stinner@gmail.com> wrote:
I would like to completely remove the feature to be able to implement further optimizations.
This seems reasonable to me. I've never used or needed this special build; StackOverflow has no mention of it; and a Google search comes up nearly empty. That said, it might be worthwhile to check with Jeremy to get his thoughts before removing his code.
Raymond
participants (3)
-
Jeremy Hylton
-
Raymond Hettinger
-
Victor Stinner