Re: [Python-Dev] cpython: os.sendfile(): on Linux if offset parameter is passed as NULL we were

On Tue, 19 Apr 2011 09:47:21 +0200 giampaolo.rodola python-checkins@python.org wrote:
http://hg.python.org/cpython/rev/8c49f7fbba1d changeset: 69437:8c49f7fbba1d user: Giampaolo Rodola' g.rodola@gmail.com date: Tue Apr 19 09:47:16 2011 +0200 summary: os.sendfile(): on Linux if offset parameter is passed as NULL we were erroneously returning a (bytes_sent, None) tuple instead of bytes_sent
Do we have tests for this?
Regards
Antoine.

No we haven't. I plan to make a unique commit for offset=None on Linux and a serie of other tests I have implemented for py-sendfile module [1]. In details test for small file, empty file and (most important) large file: http://code.google.com/p/py-sendfile/source/browse/trunk/test/test_sendfile....
[1] http://code.google.com/p/py-sendfile
--- Giampaolo http://code.google.com/p/pyftpdlib http://code.google.com/p/psutil
2011/4/19 Antoine Pitrou solipsis@pitrou.net:
On Tue, 19 Apr 2011 09:47:21 +0200 giampaolo.rodola python-checkins@python.org wrote:
http://hg.python.org/cpython/rev/8c49f7fbba1d changeset: 69437:8c49f7fbba1d user: Giampaolo Rodola' g.rodola@gmail.com date: Tue Apr 19 09:47:16 2011 +0200 summary: os.sendfile(): on Linux if offset parameter is passed as NULL we were erroneously returning a (bytes_sent, None) tuple instead of bytes_sent
Do we have tests for this?
Regards
Antoine.
Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/g.rodola%40gmail.com

On 4/20/2011 2:09 PM, Giampaolo Rodolà wrote:
No we haven't.
"No we haven't" what? Such out-of-context responses exemplify why top-posting is greatly inferior for readers, who vastly outnumber the one writer. If that line had been put where it belongs, right after what it refers to, it would have been clear.
participants (3)
-
Antoine Pitrou
-
Giampaolo Rodolà
-
Terry Reedy