Re: [Python-Dev] [Python-checkins] r43126 - in python/trunk: Doc/lib/libsocket.tex Lib/socket.py Lib/test/test_socket.py Misc/NEWS Modules/socketmodule.c
[attribution lost]
Looking into the library, I see many accessor functions starting with either get_ or get; however, I don't recall why that could have been relevant for socket objects.
[attribution lost]
If you think that should be changed to attributes, we should do that.
[Guido]
Accessor functions are typical for APIs translated too literally from Java. (threading.py being an example :-( )
I'd like to change this as long as we're doing greenfield API design.
[Georg Brandl]
Does that mean to change it to attributes? (since I'm no professional BDFL channeler I could have misread your sentence ;)
Yup, that's what it means. In addition, the "greenfield" part meant specifically they should be changed to read-only attributes. One trick to professional channeling is to do the Pythonic thing, and then just pretend you read Guido's mind. Of course I'm _way_ beyond that :-)
Tim Peters wrote:
[Guido]
Accessor functions are typical for APIs translated too literally from Java. (threading.py being an example :-( )
I'd like to change this as long as we're doing greenfield API design.
[Georg Brandl]
Does that mean to change it to attributes? (since I'm no professional BDFL channeler I could have misread your sentence ;)
Yup, that's what it means. In addition, the "greenfield" part meant specifically they should be changed to read-only attributes.
Thank you! Changed in rev. 43196.
One trick to professional channeling is to do the Pythonic thing, and then just pretend you read Guido's mind. Of course I'm _way_ beyond that :-)
One day, I want to become like you! ;) Cheers, Georg
participants (2)
-
Georg Brandl -
Tim Peters