Patch for trunk test_winsound.py (fixes my buildbot)
winsound.Beep fails for me on the 'x86 2k8 trunk' build slave, which is a virtual Windows Server 2008 instance running under Hyper-V. Not surprisingly, there's not a single audio-related device on this system. The attached patch to test_winsound.py incorporates the _have_soundcard() checks to the BeepTest class, which fixes the problem for me. (I've also tested the patch on a Vista system (that does have a soundcard) and everything works as expected.) Trent.
Trent Nelson wrote:
winsound.Beep fails for me on the 'x86 2k8 trunk' build slave, which is a virtual Windows Server 2008 instance running under Hyper-V. Not surprisingly, there's not a single audio-related device on this system. The attached patch to test_winsound.py incorporates the _have_soundcard() checks to the BeepTest class, which fixes the problem for me. (I've also tested the patch on a Vista system (that does have a soundcard) and everything works as expected.)
Trent, While the patches are appreciated, please submit them to the tracker at bugs.python.org rather than mailing them directly to this list. Regards, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia --------------------------------------------------------------- http://www.boredomandlaziness.org
Nick Coghlan wrote:
While the patches are appreciated, please submit them to the tracker at bugs.python.org rather than mailing them directly to this list.
This comment doesn't apply to your recent posts - looks like those have all been checked in already ;) Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia --------------------------------------------------------------- http://www.boredomandlaziness.org
On Wed, Mar 5, 2008 at 2:18 AM, Nick Coghlan <ncoghlan@gmail.com> wrote:
Nick Coghlan wrote:
While the patches are appreciated, please submit them to the tracker at bugs.python.org rather than mailing them directly to this list.
This comment doesn't apply to your recent posts - looks like those have all been checked in already ;)
Just to follow up on what Nick said, you should submit patches to the tracker. While it's usually pretty easy to submit really small things like this to the mailing list, it has two negative effects: 1) clutters the mailing list with trivial things many people may not care about, 2) it can easily be lost/forgotten. Typically the only reason we post an actual patch on python-dev is to spawn wider discussion. Generally, patches should be posted as links to the tracker rather than inline. But keep the patches coming! Cheers, n
participants (3)
-
Neal Norwitz -
Nick Coghlan -
Trent Nelson