minor PR 22981 waiting review ~20 days: https://github.com/python/cpython/pull/22981
PR 22981 is a minor update to doctest to allow it to safely consume modules which contain objects that cause inspect.unwrap to throw. I believe the review comments in the PR have been addressed at this point for ~20 days. The patch is relatively small, reviews are done, but it is unmerged. Is there a way to "bump" the request for review? thank you, -Alfred
Alfred Perlstein writes:
PR 22981 is a minor update to doctest to allow it to safely consume modules which contain objects that cause inspect.unwrap to throw.
I believe the review comments in the PR have been addressed at this point for ~20 days. The patch is relatively small, reviews are done, but it is unmerged.
Is there a way to "bump" the request for review?
The most direct way is post an update requesting review to the issue, which will notify those subscribed to it. Your message to python-dev is the slightly louder way to do that. (In the sense that will be seen by more committers, but of course a random core person is definitely less likely to do anything than someone who's posted to the issue.) Those are the "traditional" ways. There are usually quite a few people about in the discourse server. I'm not sure whether asking for a committer's attention there is appropriate (I'm an email-based person, not really familiar with the discourse usage). Check the archives and see if people do that, I guess. You seem to be very familiar with review processes, so it probably doesn't apply to you, but for completeness I'll mention the core-mentorship mailing list, where you can get advice from someone on how the process works and what committers are looking for in a PR. Typically they will also commit one or more of the mentee's PRs in the process. This isn't an appropriate venue if you just want to make sure that your contribution's status is noticed, though.
Hello, I am trying to sort out what can be done for bpo-35753 /
https://github.com/python/cpython/pull/22981
Basically any module that does "from unittest.mock import call" will
crash the doctest scanner.
At this point I'm not sure how to proceed at this point, there is some
different ideas on how to fix it, I guess I could try to fix this
differently, however I am a little worried that the different fix
suggested in the PR will be higher risk, that said if folks would be up
for reviewing this change I would give it a shot to code it up.
Can't tell right now if there's no interest in reviewing this patch
because there is a feeling that it should be done differently, or just
lack of interest in doctest.
Can I get clued in on what is the best way forward? I am happy to redo
patch, but unsure there is enough interest in this problem for an
alternative patch to be reviewed.
thanks,
-Alfred
-------- Forwarded Message --------
Subject: [Python-Dev] minor PR 22981 waiting review ~20 days:
https://github.com/python/cpython/pull/22981
Date: Mon, 14 Dec 2020 13:25:36 -0800
From: Alfred Perlstein
participants (2)
-
Alfred Perlstein -
Stephen J. Turnbull