I'm working on a patch for the Python launcher. I built Python (current tip, on MS Windows, with VS 2015), and I've just noticed that hg status shows:
hg status -mard M Doc\using\windows.rst M PC\launcher.c M Python\importlib.h
I didn't change importlib.h, and I don't see that the changes I did make would affect importlib. I presume I'm OK *not* including the importlib.h change in my patch? Paul PS By the way, the Windows build process is beautifully clean these days. Many thanks to Steve Dower and whoever else has worked on streamlining it!
On Fri, Feb 13, 2015 at 4:09 PM, Paul Moore <p.f.moore@gmail.com> wrote:
I'm working on a patch for the Python launcher. I built Python (current tip, on MS Windows, with VS 2015), and I've just noticed that hg status shows:
hg status -mard M Doc\using\windows.rst M PC\launcher.c M Python\importlib.h
I didn't change importlib.h, and I don't see that the changes I did make would affect importlib. I presume I'm OK *not* including the importlib.h change in my patch?
Yes, importlib.h changes should never be included in a patch (it would make the patch extremely huge for no benefit). It's strange that you're getting modifications, though; I can't reproduce on Linux (and don't have quick access to Windows right now). Make sure you're definitely at tip, and if it's still changing please open an issue. -- Zach
On Fri, Feb 13, 2015 at 3:49 PM, Zachary Ware <zachary.ware+pydev@gmail.com> wrote:
On Fri, Feb 13, 2015 at 4:09 PM, Paul Moore <p.f.moore@gmail.com> wrote:
I'm working on a patch for the Python launcher. I built Python (current tip, on MS Windows, with VS 2015), and I've just noticed that hg status shows:
hg status -mard M Doc\using\windows.rst M PC\launcher.c M Python\importlib.h
I didn't change importlib.h, and I don't see that the changes I did make would affect importlib. I presume I'm OK *not* including the importlib.h change in my patch?
Yes, importlib.h changes should never be included in a patch (it would
Unless they should. :) E.g. you modified importlib/_bootstrap.py, the marshal format, bytecodes, etc. -eric
On Fri, Feb 13, 2015 at 4:56 PM, Eric Snow <ericsnowcurrently@gmail.com> wrote:
On Fri, Feb 13, 2015 at 3:49 PM, Zachary Ware <zachary.ware+pydev@gmail.com> wrote:
Yes, importlib.h changes should never be included in a patch (it would
Unless they should. :) E.g. you modified importlib/_bootstrap.py, the marshal format, bytecodes, etc.
If I'm not mistaken, the devguide suggests leaving generated files out of patches, though I can't find where to link to it. If not, it probably should :). Generated files ought to be generated by the build process the same way on any system, so leaving them in the patch amounts to unnecessary noise, especially in the case of importlib.h which is not human-readable (and huge). In the case of a generated file being affected by a patch, a friendly reminder that files will need to be regenerated should be included when posting the patch, though. -- Zach
On 13 February 2015 at 22:49, Zachary Ware <zachary.ware+pydev@gmail.com> wrote:
It's strange that you're getting modifications, though; I can't reproduce on Linux (and don't have quick access to Windows right now). Make sure you're definitely at tip, and if it's still changing please open an issue.
Definitely at tip. I just redid the build and confirmed it's reproducible. There is a message generated during the build that says importlib.h has changed. Reported at http://bugs.python.org/issue23461 Paul.
participants (3)
-
Eric Snow -
Paul Moore -
Zachary Ware