bpo-32972: Add unittest.AsyncioTestCase review (for 3.8?)
Hi everyone, I added a PR to add a sub-class of unittest.TestCase that makes it possible to write async test methods. I wrote this a few months ago and it is waiting on core review. Is there a core dev that can take up this review? I would love to have this functionality in the core. Lukasz - should we add this to Python 3.8 or is it too late for feature additions? BPO link: https://bugs.python.org/issue32972 <https://bugs.python.org/issue32972> Github PR: https://github.com/python/cpython/pull/10296 <https://github.com/python/cpython/pull/10296> cheers, dave. -- "State and behavior. State and behavior. If it doesn’t bundle state and behavior in a sensible way, it should not be an object, and there should not be a class that produces it." eevee
Hi David, I cannot comment on the PR, but since the functionality is asyncio-specific, I would suggest moving it to a dedicate `asyncio.testing` module, or something similar, rather than leaving it in `unittest` proper. Regards Antoine. On Tue, 5 Feb 2019 07:05:05 -0500 David Shawley <daveshawley@gmail.com> wrote:
Hi everyone, I added a PR to add a sub-class of unittest.TestCase that makes it possible to write async test methods. I wrote this a few months ago and it is waiting on core review. Is there a core dev that can take up this review? I would love to have this functionality in the core.
Lukasz - should we add this to Python 3.8 or is it too late for feature additions?
BPO link: https://bugs.python.org/issue32972 <https://bugs.python.org/issue32972> Github PR: https://github.com/python/cpython/pull/10296 <https://github.com/python/cpython/pull/10296>
cheers, dave. -- "State and behavior. State and behavior. If it doesn’t bundle state and behavior in a sensible way, it should not be an object, and there should not be a class that produces it." eevee
On 2/5/2019 11:44 AM, Antoine Pitrou wrote:
I cannot comment on the PR, but since the functionality is asyncio-specific, I would suggest moving it to a dedicate `asyncio.testing` module, or something similar, rather than leaving it in `unittest` proper.
That is one of the options discussed on the issue. On Tue, 5 Feb 2019 07:05:05 -0500
David Shawley <daveshawley@gmail.com> wrote:
Hi everyone, I added a PR to add a sub-class of unittest.TestCase that makes it possible to write async test methods. I wrote this a few months ago and it is waiting on core review. Is there a core dev that can take up this review? I would love to have this functionality in the core.
Lukasz - should we add this to Python 3.8 or is it too late for feature additions?
Features can be added until beta1, and until that, additions are not the release manager decision.
BPO link: https://bugs.python.org/issue32972 <https://bugs.python.org/issue32972> Github PR: https://github.com/python/cpython/pull/10296 <https://github.com/python/cpython/pull/10296>
All or most of the relevant people are nosy on the issue. So a reminder there would be appropriate. However, from my cursory scan, it is not clear if the 5 core devs involved (marked by blue and yellow snakes) agree on exactly what more should be added. Perhaps you should summarize what you think there is and is not agreement on. -- Terry Jan Reedy
participants (3)
-
Antoine Pitrou -
David Shawley -
Terry Reedy