Issue13210 : Support Visual Studio 2010
Hi, Does anyone object if I submit my patches sxs.patch and errnomodule.patch? These allow python to work correctly when built with vs2010. There is also the PCBuild10.patch, but that can wait. I'm sure a number of people are regularly building python using vs2010 using their own modified solutions, but having the sources in a constant state of patching is a nuiscance so I think we ought to at least make the source code work with it, regardless of having a proper solution for it. K
2012/3/31 Kristján Valur Jónsson <kristjan@ccpgames.com>:
Hi,
Does anyone object if I submit my patches sxs.patch and errnomodule.patch?
These allow python to work correctly when built with vs2010.
There is also the PCBuild10.patch, but that can wait. I'm sure a number of people are regularly building python using vs2010 using their own modified solutions, but having the sources in a constant state of patching is a nuiscance so I think we ought to at least make the source code work with it, regardless of having a proper solution for it.
Go ahead. As listed on the issue, there is a repo where building from VS2010 "works" but the port is not complete as not all tests are passing. I will complete it.
Does anyone object if I submit my patches sxs.patch and errnomodule.patch?
These allow python to work correctly when built with vs2010.
Please see my review: "allow to work correctly" is not a good explanation of what it does, and why it does that. As it is highly counter-intuitive, it needs at least justification. I'm trying to investigate whether it is actually correct (and that it works for CCP is not sufficient proof that it is correct). Also, please clarify what branches you would apply this to. 3.3 is certainly fine; for any other branches, I'd like to point out that this is not a bug fix.
There is also the PCBuild10.patch, but that can wait.
Indeed, it shouldn't be added at all. Instead, the PCbuild tree should become a VS2010 (or VS2012) tree ultimately. Regards, Martin
participants (3)
-
Brian Curtin -
Kristján Valur Jónsson -
martin＠v.loewis.de