test_pyclbr is failing due to the changes in random: test_pyclbr l1=['Random'] l2=['CoreGenerator'] ignore=('_verify',) class=<class 'random.Random'> test test_pyclbr failed -- Traceback (most recent call last): File "/home/neal/build/python/dist/src/Lib/test/test_pyclbr.py", line 146, in test_others cm('random', ignore=('_verify',)) # deleted File "/home/neal/build/python/dist/src/Lib/test/test_pyclbr.py", line 97, in checkModule self.assertListEq(real_bases, pyclbr_bases, ignore) File "/home/neal/build/python/dist/src/Lib/test/test_pyclbr.py", line 33, in assertListEq self.fail("%r missing" % item) File "/home/neal/build/python/dist/src/Lib/unittest.py", line 260, in fail raise self.failureException, msg AssertionError: 'Random' missing Neal
It would be helpful if the pyclbr tests could be re-written so that they don't depend on an arbitrary set of unrelated modules. While people should run the full test suite, it seems common to run a limited set of tests when you're changing a single module and test_pyclbr always gets skipped. (I also wonder how useful this pyclbr module is for modern Python, since almost every module in test_pyclbr that has been modified in the last year has caused tests to fail.) Jeremy
I disagree. I maintain pyclbr.py (having mostly rewritten its main loop last August and another major update more recently) and usually a failure is now a symptom of a bug in pyclbr.
That was true before my most recent rewrite. After it, I was able to add back a bunch of tests that were commented out, and vastly reduce the number of exceptions for other tests. It's still not perfect, but a lot more so. pyclbr is used by IDLE's class and path browser commands, so it can't be deprecated. I'll look into the most recent random failure. --Guido van Rossum (home page: http://www.python.org/~guido/)
It would be helpful if the pyclbr tests could be re-written so that they don't depend on an arbitrary set of unrelated modules. While people should run the full test suite, it seems common to run a limited set of tests when you're changing a single module and test_pyclbr always gets skipped. (I also wonder how useful this pyclbr module is for modern Python, since almost every module in test_pyclbr that has been modified in the last year has caused tests to fail.) Jeremy
I disagree. I maintain pyclbr.py (having mostly rewritten its main loop last August and another major update more recently) and usually a failure is now a symptom of a bug in pyclbr.
That was true before my most recent rewrite. After it, I was able to add back a bunch of tests that were commented out, and vastly reduce the number of exceptions for other tests. It's still not perfect, but a lot more so. pyclbr is used by IDLE's class and path browser commands, so it can't be deprecated. I'll look into the most recent random failure. --Guido van Rossum (home page: http://www.python.org/~guido/)
participants (3)
-
Guido van Rossum -
Jeremy Hylton -
Neal Norwitz