PR checks hang because travis does not report back to github
Hi devs, I have a trivial documentation PR https://github.com/python/cpython/pull/22464 for which travis (unsurprisingly) had a successful run, https://travis-ci.com/github/python/cpython/builds/187435578 but github lists the travis build as "created" instead of "passed". https://github.com/python/cpython/pull/22464/checks?check_run_id=1188595760 I already tried closing the PR and reopening it, and also triggering the build again on travis side, but github still fails to pick up the build status. I tried creating a new PR, but it seems that github (or travis) deduplicate the build requests and still refer to the original build, so that there is still no response from travis. I also cannot find a way to terminate the checks process in github, or otherwise make it stop waiting for Godot. Is this a known issue? Is there anything I can do about it? Thanks, Stefan
This is a known issue and I have brought it up in GitHub OS Maintainers Feedback Group. It happens to other projects as well. Currently we have branch protection rule where even administrators couldnt merge the PR unless all the required checks passed. Perhaps we can relax the rule to allow administrators to merge the stuck PRs. At least temporarily until Travis/GitHub fixes it. Does this sound okay? On Sun, Oct 4, 2020, 10:44 AM Stefan Behnel <stefan_ml@behnel.de> wrote:
Hi devs,
I have a trivial documentation PR
https://github.com/python/cpython/pull/22464
for which travis (unsurprisingly) had a successful run,
https://travis-ci.com/github/python/cpython/builds/187435578
but github lists the travis build as "created" instead of "passed".
https://github.com/python/cpython/pull/22464/checks?check_run_id=1188595760
I already tried closing the PR and reopening it, and also triggering the build again on travis side, but github still fails to pick up the build status.
I tried creating a new PR, but it seems that github (or travis) deduplicate the build requests and still refer to the original build, so that there is still no response from travis.
I also cannot find a way to terminate the checks process in github, or otherwise make it stop waiting for Godot.
Is this a known issue? Is there anything I can do about it?
Thanks, Stefan _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/4TNKVOJ2... Code of Conduct: http://python.org/psf/codeofconduct/
On 10/4/2020 2:32 PM, Mariatta wrote:
This is a known issue and I have brought it up in GitHub OS Maintainers Feedback Group. It happens to other projects as well.
Currently we have branch protection rule where even administrators couldnt merge the PR unless all the required checks passed.
Perhaps we can relax the rule to allow administrators to merge the stuck PRs. At least temporarily until Travis/GitHub fixes it. Does this sound okay?
If we are told how to ping the admins, it would be better than being stuck.
On Sun, Oct 4, 2020, 10:44 AM Stefan Behnel <stefan_ml@behnel.de <mailto:stefan_ml@behnel.de>> wrote:
Hi devs,
I have a trivial documentation PR
https://github.com/python/cpython/pull/22464
for which travis (unsurprisingly) had a successful run,
https://travis-ci.com/github/python/cpython/builds/187435578
Since the details were still available, I verified 'success'. This is much better that previous stuck situations in which the details line disappeared.
but github lists the travis build as "created" instead of "passed".
https://github.com/python/cpython/pull/22464/checks?check_run_id=1188595760
I already tried closing the PR and reopening it, and also triggering the build again on travis side, but github still fails to pick up the build status.
I tried creating a new PR, but it seems that github (or travis) deduplicate the build requests and still refer to the original build, so that there is still no response from travis.
I also cannot find a way to terminate the checks process in github, or otherwise make it stop waiting for Godot.
Is this a known issue? Is there anything I can do about it?
-- Terry Jan Reedy
On Oct 4, 2020, at 15:55, Terry Reedy <tjreedy@udel.edu> wrote:
On 10/4/2020 2:32 PM, Mariatta wrote:
This is a known issue and I have brought it up in GitHub OS Maintainers Feedback Group. It happens to other projects as well. Currently we have branch protection rule where even administrators couldnt merge the PR unless all the required checks passed. Perhaps we can relax the rule to allow administrators to merge the stuck PRs. At least temporarily until Travis/GitHub fixes it. Does this sound okay?
If we are told how to ping the admins, it would be better than being stuck.
If you run into a problem like this with a stuck PR, contact the release manager for the branch directly via email. Release managers can override the restrictions and we don't always read every list immediately. Because this was a trivial change and because of time zones, I've taken the liberty of acting in Pablo's behalf: it's now merged. -- Ned Deily nad@python.org -- []
Ned Deily schrieb am 05.10.20 um 01:19:
On Oct 4, 2020, at 15:55, Terry Reedy wrote:
On 10/4/2020 2:32 PM, Mariatta wrote:
This is a known issue and I have brought it up in GitHub OS Maintainers Feedback Group. It happens to other projects as well. Currently we have branch protection rule where even administrators couldnt merge the PR unless all the required checks passed. Perhaps we can relax the rule to allow administrators to merge the stuck PRs. At least temporarily until Travis/GitHub fixes it. Does this sound okay?
If we are told how to ping the admins, it would be better than being stuck.
If you run into a problem like this with a stuck PR, contact the release manager for the branch directly via email. Release managers can override the restrictions and we don't always read every list immediately.
Because this was a trivial change and because of time zones, I've taken the liberty of acting in Pablo's behalf: it's now merged.
Thank you Ned, and good to know. Stefan
On Sun, Oct 4, 2020 at 8:34 PM Mariatta <mariatta@python.org> wrote:
Perhaps we can relax the rule to allow administrators to merge the stuck PRs. At least temporarily until Travis/GitHub fixes it. Does this sound okay?
+1 on relaxing the rule permanently. We should not give robots more rights than humans. People before Processes is the very first principle in the Agile Manifesto (and with good reason).
Hi, Would you mind reporting the issue to https://github.com/python/core-workflow/issues so we can aggregate information about this issue? Latest changes related to Travis CI. Travis CI migrated from legacy API to new GitHub Action API: https://github.com/python/core-workflow/issues/371 Removal of old webhooks: https://github.com/python/core-workflow/issues/374 Travis CI can be reported/discussed at: https://travis-ci.community/ -- If Travis CI is made optional (not mandatory), can we mark another Linux CI as mandatory? Like the "GitHub Action Ubuntu" job? I didn't pay attention to whether it's reliable or not. In my experience, no CI is reliable, and all CI need attention from time to time :-) Victor Le dim. 4 oct. 2020 à 19:46, Stefan Behnel <stefan_ml@behnel.de> a écrit :
Hi devs,
I have a trivial documentation PR
https://github.com/python/cpython/pull/22464
for which travis (unsurprisingly) had a successful run,
https://travis-ci.com/github/python/cpython/builds/187435578
but github lists the travis build as "created" instead of "passed".
https://github.com/python/cpython/pull/22464/checks?check_run_id=1188595760
I already tried closing the PR and reopening it, and also triggering the build again on travis side, but github still fails to pick up the build status.
I tried creating a new PR, but it seems that github (or travis) deduplicate the build requests and still refer to the original build, so that there is still no response from travis.
I also cannot find a way to terminate the checks process in github, or otherwise make it stop waiting for Godot.
Is this a known issue? Is there anything I can do about it?
Thanks, Stefan _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/4TNKVOJ2... Code of Conduct: http://python.org/psf/codeofconduct/
-- Night gathers, and now my watch begins. It shall not end until my death.
Victor Stinner schrieb am 05.10.20 um 12:25:
Would you mind reporting the issue to https://github.com/python/core-workflow/issues so we can aggregate information about this issue?
Done. Stefan
Stefan created https://github.com/python/core-workflow/issues/376 Victor Le lun. 5 oct. 2020 à 12:25, Victor Stinner <vstinner@python.org> a écrit :
Hi,
Would you mind reporting the issue to https://github.com/python/core-workflow/issues so we can aggregate information about this issue?
Latest changes related to Travis CI.
Travis CI migrated from legacy API to new GitHub Action API: https://github.com/python/core-workflow/issues/371
Removal of old webhooks: https://github.com/python/core-workflow/issues/374
Travis CI can be reported/discussed at: https://travis-ci.community/
--
If Travis CI is made optional (not mandatory), can we mark another Linux CI as mandatory? Like the "GitHub Action Ubuntu" job? I didn't pay attention to whether it's reliable or not.
In my experience, no CI is reliable, and all CI need attention from time to time :-)
Victor
Le dim. 4 oct. 2020 à 19:46, Stefan Behnel <stefan_ml@behnel.de> a écrit :
Hi devs,
I have a trivial documentation PR
https://github.com/python/cpython/pull/22464
for which travis (unsurprisingly) had a successful run,
https://travis-ci.com/github/python/cpython/builds/187435578
but github lists the travis build as "created" instead of "passed".
https://github.com/python/cpython/pull/22464/checks?check_run_id=1188595760
I already tried closing the PR and reopening it, and also triggering the build again on travis side, but github still fails to pick up the build status.
I tried creating a new PR, but it seems that github (or travis) deduplicate the build requests and still refer to the original build, so that there is still no response from travis.
I also cannot find a way to terminate the checks process in github, or otherwise make it stop waiting for Godot.
Is this a known issue? Is there anything I can do about it?
Thanks, Stefan _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/4TNKVOJ2... Code of Conduct: http://python.org/psf/codeofconduct/
-- Night gathers, and now my watch begins. It shall not end until my death.
-- Night gathers, and now my watch begins. It shall not end until my death.
participants (6)
-
Mariatta -
Ned Deily -
Simon Cross -
Stefan Behnel -
Terry Reedy -
Victor Stinner