Hello I got the latest copy of python source from svn and was trying to build it on Windows Vista (32 bit) using Microsoft Visual Express 2008. I got the following error: 5>"C:\Program Files\TortoiseSVN\bin\subwcrev.exe" .. ..\Modules\getbuildinfo.c "E:\coding\py3kclean\py3k\PCbuild\Win32-temp-Debug\pythoncore\\getbuildinfo2.c" 5>'C:\Program' is not recognized as an internal or external command, Adding an extra set of quotes around the command seems to fix this. I've attached a patch. Thanks Prasun
Adding an extra set of quotes around the command seems to fix this. I've attached a patch.
This is puzzling: a) AFAICT, the code works on all other system as it stands, and b) putting this many quotes into the command line is not plausible. Do you have any strange settings on your computer, such as using a non-standard cmd shell? Regards, Martin
Le dimanche 23 janvier 2011 à 19:18 +0100, "Martin v. Löwis" a écrit :
Adding an extra set of quotes around the command seems to fix this. I've attached a patch.
Hey! I already wrote exactly the same patch! But I didn't propose it upstream because I was unable to reproduce the bug.
This is puzzling: a) AFAICT, the code works on all other system as it stands,
I had this issue already twice, but later (after a reboot? I don't remember) it worked again (without the patch). It might be related to an upgrade of TortoiseSVN (try to upgrade TortoiseSVN without rebooting).
b) putting this many quotes into the command line is not plausible.
""c:\path\to\subwcrev.exe" arg1 arg2 ..." just works. I don't understand why (strange syntax), but it works :-) When I had the problem, it worked with extra quotes, but not without. It is strange because the program ("c:\path\to\subwcrev.exe") existed!? Victor
""c:\path\to\subwcrev.exe" arg1 arg2 ..." just works. I don't understand why (strange syntax), but it works :-)
When I had the problem, it worked with extra quotes, but not without. It is strange because the program ("c:\path\to\subwcrev.exe") existed!?
I'd really like to understand it before changing it. The part "it sometimes works, then fails" is particularly puzzling, and indicates that the *actual* problem is entirely unrelated to the quoting. Regards, Martin
On Sun, Jan 23, 2011 at 2:10 PM, "Martin v. Löwis"
""c:\path\to\subwcrev.exe" arg1 arg2 ..." just works. I don't understand why (strange syntax), but it works :-)
When I had the problem, it worked with extra quotes, but not without. It is strange because the program ("c:\path\to\subwcrev.exe") existed!?
I'd really like to understand it before changing it. The part "it sometimes works, then fails" is particularly puzzling, and indicates that the *actual* problem is entirely unrelated to the quoting.
I used ProcMon to track down the actual command that the system() call creates. The unmodified code produces this: C:\Windows\system32\cmd.exe /c "C:\Program Files\TortoiseSVN\bin\subwcrev.exe" .. ..\Modules\getbuildinfo.c "E:\coding\py3k\PCbuild\Win32-temp-pgi\pythoncore\\getbuildinfo2.c" whereas my patch produces this: C:\Windows\system32\cmd.exe /c ""C:\Program Files\TortoiseSVN\bin\subwcrev.exe" .. ..\Modules\getbuildinfo.c "E:\coding\py3k\PCbuild\Win32-temp-pgi\pythoncore\\getbuildinfo2.c"" I pasted those two lines on the command prompt. The first results in the error "'C:\Program' is not recognized ...... ". The second one does the right thing. It would be great if someone could run ProcMon on a "normal" system and see what command is created. Thanks Prasun
participants (4)
-
"Martin v. Löwis" -
Prasun Ratn -
prasun3＠gmail.com
-
Victor Stinner