On 12.04.2011 23:05, nadeem.vawda wrote:
http://hg.python.org/cpython/rev/0010cc5f22d4 changeset: 69275:0010cc5f22d4 user: Nadeem Vawda firstname.lastname@example.org date: Tue Apr 12 23:02:42 2011 +0200 summary: Fix 64-bit safety issue in BZ2Compressor and BZ2Decompressor.
files: Lib/test/test_bz2.py | 36 +++++++++++++++++++++++++++++++- Modules/_bz2module.c | 33 +++++++++++++++++++++-------- 2 files changed, 59 insertions(+), 10 deletions(-)
diff --git a/Lib/test/test_bz2.py b/Lib/test/test_bz2.py --- a/Lib/test/test_bz2.py +++ b/Lib/test/test_bz2.py
for reviewing and "hg log" purposes it would be good to include a bit more information in the commit message, like where the safety issue was and what its potential implications were.
(Of course that is different if there is an issue on the tracker to refer to; usually the issue is explained clearly in the issue.)
Thanks for the feedback. I'll be sure to include more information in my future commit messages.