Update on labels to be used on GitHub
We now have two sets of labels for representing cherry-picking statuses: "backport to N.M" and "cherry-pick for N.M". The former are to help keep track of what branches a PR should be cherry-picked *to* and can be removed once the PR for a cherry-pick has been created (you can add a comment like "cherry-picked from GH-NN" to make the link between the PRs)*.* The latter labels are to signify that the PR is a cherry-pick *itself*. As with all aspects of the new GitHub workflow, we will give this a solid try for about a month and then we can re-evaluate whether we like this approach or want a more traditional prefix format in the title to represent the same thing.
2017-02-13 21:08 GMT+01:00 Brett Cannon <brett@python.org>:
We now have two sets of labels for representing cherry-picking statuses: "backport to N.M" and "cherry-pick for N.M". The former are to help keep track of what branches a PR should be cherry-picked to and can be removed once the PR for a cherry-pick has been created (you can add a comment like "cherry-picked from GH-NN" to make the link between the PRs).
The first time I looked at the "backport to 3.6" flag, I understood that the change was written on the 3.6 branch and asked to rebase the change on 3.6. If I was confused, I'm sure that someone else will be confused as well :-) What do you think of renaming the label to "need 3.6 backport" (or "need backport to 3.6")? Victor
On Mon, 13 Feb 2017 at 14:43 Victor Stinner <victor.stinner@gmail.com> wrote:
We now have two sets of labels for representing cherry-picking statuses: "backport to N.M" and "cherry-pick for N.M". The former are to help keep track of what branches a PR should be cherry-picked to and can be removed once the PR for a cherry-pick has been created (you can add a comment
2017-02-13 21:08 GMT+01:00 Brett Cannon <brett@python.org>: like
"cherry-picked from GH-NN" to make the link between the PRs).
The first time I looked at the "backport to 3.6" flag, I understood that the change was written on the 3.6 branch and asked to rebase the change on 3.6. If I was confused, I'm sure that someone else will be confused as well :-)
What do you think of renaming the label to "need 3.6 backport" (or "need backport to 3.6")?
That's fine by me. Anyone else have an opinion?
On Tue, Feb 14, 2017 at 11:32 AM, Brett Cannon <brett@python.org> wrote:
On Mon, 13 Feb 2017 at 14:43 Victor Stinner <victor.stinner@gmail.com> wrote:
2017-02-13 21:08 GMT+01:00 Brett Cannon <brett@python.org>:
We now have two sets of labels for representing cherry-picking statuses: "backport to N.M" and "cherry-pick for N.M". The former are to help keep track of what branches a PR should be cherry-picked to and can be removed once the PR for a cherry-pick has been created (you can add a comment like "cherry-picked from GH-NN" to make the link between the PRs).
The first time I looked at the "backport to 3.6" flag, I understood that the change was written on the 3.6 branch and asked to rebase the change on 3.6. If I was confused, I'm sure that someone else will be confused as well :-)
What do you think of renaming the label to "need 3.6 backport" (or "need backport to 3.6")?
That's fine by me. Anyone else have an opinion?
To propose another color for the bikeshed, what about having labels for each branch along with "needs backport" and "cherry-pick" labels? PRs that should be backported get "needs backport" and each branch that should get the patch, and cherry-pick PRs get exactly one branch label and the "cherry-pick" label. I think this would make it easier to see which branch a particular PR is against from the PR list. -- Zach
2017-02-14 18:43 GMT+01:00 Zachary Ware <zachary.ware+pydev@gmail.com>:
To propose another color for the bikeshed, what about having labels for each branch along with "needs backport" and "cherry-pick" labels?
Oh right, labels have colors. I propose pink for "needs backport" and yellow for "cherry-pick"! Just kidding, sorry ;-) Victor
On 2017-02-14 17:58, Victor Stinner wrote:
2017-02-14 18:43 GMT+01:00 Zachary Ware <zachary.ware+pydev@gmail.com>:
To propose another color for the bikeshed, what about having labels for each branch along with "needs backport" and "cherry-pick" labels?
Oh right, labels have colors. I propose pink for "needs backport" and yellow for "cherry-pick"!
Just kidding, sorry ;-)
Surely the colour for "cherry-pick" should be the colour of cherries! :-)
On Tue, 14 Feb 2017 at 10:13 MRAB <python@mrabarnett.plus.com> wrote:
On 2017-02-14 17:58, Victor Stinner wrote:
2017-02-14 18:43 GMT+01:00 Zachary Ware <zachary.ware+pydev@gmail.com>:
To propose another color for the bikeshed, what about having labels for each branch along with "needs backport" and "cherry-pick" labels?
Oh right, labels have colors. I propose pink for "needs backport" and yellow for "cherry-pick"!
Just kidding, sorry ;-)
Surely the colour for "cherry-pick" should be the colour of cherries! :-)
Since the wording keeps throwing people I have renamed "backport to N.M" to "needs backport to N.M". I left the "cherry-pick for N.M" labels but made them a shade of pink (I associate cherry red with "bug" too much to switch over to red entirely :) .
participants (4)
-
Brett Cannon -
MRAB -
Victor Stinner -
Zachary Ware