Re: [Python-Dev] [Python-checkins] cpython: Close #20053: ignore default pip config settings
On Tue, Feb 4, 2014 at 6:03 AM, nick.coghlan <python-checkins@python.org> wrote:
http://hg.python.org/cpython/rev/1b8ba1346e67 changeset: 88955:1b8ba1346e67 user: Nick Coghlan <ncoghlan@gmail.com> date: Tue Feb 04 23:02:36 2014 +1000 summary: Close #20053: ignore default pip config settings
ensurepip now sets PIP_CONFIG_FILE to os.devnull before import pip from the wheel file. This also ensures venv ignores the default settings when bootstrapping pip.
files: Lib/ensurepip/__init__.py | 9 ++++-- Lib/test/test_ensurepip.py | 16 +++++++++++ Lib/test/test_venv.py | 37 +++++++++++++++++++------ Misc/NEWS | 3 ++ 4 files changed, 53 insertions(+), 12 deletions(-)
This changeset caused the Windows buildbots to go red. Excerpt from one of the logs: ====================================================================== FAIL: test_with_pip (test.test_venv.EnsurePipTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_venv.py", line 349, in test_with_pip self.assertEqual(err, "") AssertionError: 'C:\\Users\\Buildbot\\AppData\\Local\\Temp[57 chars]\r\n' != '' - C:\Users\Buildbot\AppData\Local\Temp\tmpkwelerus\Scripts\python_d.exe: No module named pip -- Jeremy Kloth
On 6 Feb 2014 05:27, "Jeremy Kloth" <jeremy.kloth@gmail.com> wrote:
On Tue, Feb 4, 2014 at 6:03 AM, nick.coghlan <python-checkins@python.org>
wrote:
http://hg.python.org/cpython/rev/1b8ba1346e67 changeset: 88955:1b8ba1346e67 user: Nick Coghlan <ncoghlan@gmail.com> date: Tue Feb 04 23:02:36 2014 +1000 summary: Close #20053: ignore default pip config settings
ensurepip now sets PIP_CONFIG_FILE to os.devnull before import pip from the wheel file. This also ensures venv ignores the default settings when bootstrapping pip.
files: Lib/ensurepip/__init__.py | 9 ++++-- Lib/test/test_ensurepip.py | 16 +++++++++++ Lib/test/test_venv.py | 37 +++++++++++++++++++------ Misc/NEWS | 3 ++ 4 files changed, 53 insertions(+), 12 deletions(-)
This changeset caused the Windows buildbots to go red. Excerpt from one of the logs:
====================================================================== FAIL: test_with_pip (test.test_venv.EnsurePipTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\buildbot.python.org \3.x.kloth-win64\build\lib\test\test_venv.py", line 349, in test_with_pip self.assertEqual(err, "") AssertionError: 'C:\\Users\\Buildbot\\AppData\\Local\\Temp[57 chars]\r\n' != '' - C:\Users\Buildbot\AppData\Local\Temp\tmpkwelerus\Scripts\python_d.exe: No module named pip
Yeah, I noticed that yesterday :( I already reopened the issue, and flagged it as affecting the buildbots. Unfortunately, the only idea I've had for a possible culprit turned out not to be the problem (I added a separate test specifically to check the relevant cross-platform assumption, and that passed on Windows, but this test still failed) See the last few comments on http://bugs.python.org/issue20053 for details. Cheers, Nick.
-- Jeremy Kloth
participants (2)
-
Jeremy Kloth -
Nick Coghlan