Re: [Python-Dev] cpython (merge 3.3 -> default): Merge fix from 3.3 into default.
On Sun, 1 Sep 2013 23:02:17 +0200 (CEST) tim.peters <python-checkins@python.org> wrote:
http://hg.python.org/cpython/rev/25211a22228b changeset: 85495:25211a22228b parent: 85493:267e09700978 parent: 85494:8efcf3c823f9 user: Tim Peters <tim@python.org> date: Sun Sep 01 16:01:46 2013 -0500 summary: Merge fix from 3.3 into default.
Fix issue 18889: test_sax: multiple failures on Windows desktop.
"The fix" is to tell Mercurial that the test files are binary.
Windows developers: to get the correct line endings in your checkout, delete Lib\test\xmltestdata, and then "hg revert" that directory.
Why the Windows buildbots didn't fail test_sax remains a mystery :-(
Probably because they don't have the hgeol extension enabled. Regards Antoine.
On 9/1/2013 5:04 PM, Antoine Pitrou wrote:
On Sun, 1 Sep 2013 23:02:17 +0200 (CEST) tim.peters <python-checkins@python.org> wrote:
Windows developers: to get the correct line endings in your checkout, delete Lib\test\xmltestdata, and then "hg revert" that directory.
Or, in Tortoisehg Workbenck, select the four Working Directory patch entries, right click, and revert.
Why the Windows buildbots didn't fail test_sax remains a mystery :-(
Probably because they don't have the hgeol extension enabled.
Since the tests also failed on installed Python, it seems that the .msi installer is created in a repository with the extension enabled. If so, I think that the buildbots should have the extension enabled also, so that they are testing Python as it will be distributed. Or we could stop supporting Notepad and change what we distribute ;-). -- Terry Jan Reedy
Terry Reedy <tjreedy@udel.edu> writes:
On 9/1/2013 5:04 PM, Antoine Pitrou wrote:
Probably because they don't have the hgeol extension enabled.
Yes, I believe that's correct, at least for my Windows buildbots.
Since the tests also failed on installed Python, it seems that the .msi installer is created in a repository with the extension enabled. If so, I think that the buildbots should have the extension enabled also, so that they are testing Python as it will be distributed.
If it should be enabled, I believe it will have to be done globally, so affecting all buildbot branches (not that it sounds like that would be an issue). The individual branch repositories are physically removed at times (such as during a failure to update, which escalates to a removal followed by full clone, as well as I believe during a custom build), so I don't believe persistent local changes to the repository's own hgrc are possible in a reliable way. In the event we did want per-repository control, then I think we'd need to have some sort of additional script that ran as part of the buildbot build process to ensure the right contents for the local repository hgrc following a clone, or just prior to the update step. -- David
participants (3)
-
Antoine Pitrou -
David Bolen -
Terry Reedy