Requesting a code review for #29560 (bpo-26175: Implement io.IOBase interface for SpooledTemporaryFile)
31 Dec
2021
31 Dec
'21
8:11 a.m.
Hi all, I submitted my first PR against Python a month or so ago and was wondering if someone could take a quick look at it and let me know if anything needs to be fixed before it can be merged. It's a pretty simple change (mostly just boilerplate delegation) that allows SpooledTemporaryFile objects to be used like all other io.IOBase objects. This brings it more inline with the documentation, as well as fixes a variety of use cases that require the `seekable`, `readable`, etc. methods to be available on it. Python bug: https://bugs.python.org/issue26175 Current PR: https://github.com/python/cpython/pull/29560 Thanks! Carey
845
Age (days ago)
845
Last active (days ago)
0 comments
1 participants
participants (1)
-
Carey Metcalfe