Re: [Python-Dev] [Python-checkins] r87537 - in python/branches/py3k: Doc/library/struct.rst Doc/whatsnew/3.2.rst Lib/test/test_struct.py Lib/wave.py Misc/NEWS Modules/_struct.c

On 12/28/2010 8:26 AM, victor.stinner wrote:
Author: victor.stinner Date: Tue Dec 28 14:26:42 2010 New Revision: 87537
Log: Issue #10783: struct.pack() doesn't encode implicitly unicode to UTF-8
Modified: python/branches/py3k/Doc/whatsnew/3.2.rst ============================================================================== --- python/branches/py3k/Doc/whatsnew/3.2.rst (original) +++ python/branches/py3k/Doc/whatsnew/3.2.rst Tue Dec 28 14:26:42 2010 @@ -1705,3 +1705,7 @@
(Contributed by Georg Brandl and Mattias Brändström; `appspot issue 53094<http://codereview.appspot.com/53094>`_.) + +* :func:`struct.pack` doesn't encode implicitly unicode to UTF-8 anymore:
That phrasing is awkward at best. I believe you mean "struct.pack no longer implicitly encodes unicode to UTF-8", which will be clearer to most people. Terry

Le mardi 28 décembre 2010 à 15:22 -0500, Terry Reedy a écrit :
On 12/28/2010 8:26 AM, victor.stinner wrote:
Author: victor.stinner Date: Tue Dec 28 14:26:42 2010 New Revision: 87537
Log: Issue #10783: struct.pack() doesn't encode implicitly unicode to UTF-8
Modified: python/branches/py3k/Doc/whatsnew/3.2.rst ============================================================================== --- python/branches/py3k/Doc/whatsnew/3.2.rst (original) +++ python/branches/py3k/Doc/whatsnew/3.2.rst Tue Dec 28 14:26:42 2010 @@ -1705,3 +1705,7 @@
(Contributed by Georg Brandl and Mattias Brändström; `appspot issue 53094<http://codereview.appspot.com/53094>`_.) + +* :func:`struct.pack` doesn't encode implicitly unicode to UTF-8 anymore:
That phrasing is awkward at best.
Sorry, I am still learning english :-)
I believe you mean "struct.pack no longer implicitly encodes unicode to UTF-8", which will be clearer to most people.
Yes, done in r87559 Victor

On Wed, 29 Dec 2010 00:38:13 +0100, Victor Stinner <victor.stinner@haypocalc.com> wrote:
Le mardi 28 décembre 2010 à 15:22 -0500, Terry Reedy a écrit :
On 12/28/2010 8:26 AM, victor.stinner wrote:
Author: victor.stinner Date: Tue Dec 28 14:26:42 2010 New Revision: 87537
Log: Issue #10783: struct.pack() doesn't encode implicitly unicode to UTF-8
Modified: python/branches/py3k/Doc/whatsnew/3.2.rst
==============================================================================
--- python/branches/py3k/Doc/whatsnew/3.2.rst (original) +++ python/branches/py3k/Doc/whatsnew/3.2.rst Tue Dec 28 14:26:42 2010 @@ -1705,3 +1705,7 @@
(Contributed by Georg Brandl and Mattias Brändström; `appspot issue 53094<http://codereview.appspot.com/53094>`_.) + +* :func:`struct.pack` doesn't encode implicitly unicode to UTF-8 anymore:
That phrasing is awkward at best.
Sorry, I am still learning english :-)
I believe you mean "struct.pack no longer implicitly encodes unicode to UTF-8", which will be clearer to most people.
Yes, done in r87559
You still have two words swapped. You changed it to no longer encodes implicitly unicode but it should be no longer implicitly encodes unicode -- R. David Murray www.bitdance.com
participants (4)
-
R. David Murray
-
Stephen J. Turnbull
-
Terry Reedy
-
Victor Stinner