
Here is list of my ready for review patches. It is incomplete and contains only patches for which I don't expect objections or long discussion. Most of them are relative easy and need only formal review. Most of them wait for a review many months. https://bugs.python.org/issue23681 Have -b warn when directly comparing ints and bytes https://bugs.python.org/issue23676 Add support of UnicodeTranslateError in standard error handlers https://bugs.python.org/issue23671 string.Template doesn't work with the self keyword argument https://bugs.python.org/issue23637 Outputting warnings fails when file patch is not ASCII and message is unicode on 2.7. https://bugs.python.org/issue23622 Deprecate unrecognized backslash+letter escapes in re https://bugs.python.org/issue23611 Pickle nested names (e.g. unbound methods) with protocols < 4 https://bugs.python.org/issue23583 IDLE: printing unicode subclasses broken (again) https://bugs.python.org/issue23573 Avoid redundant memory allocations in str.find and like https://bugs.python.org/issue23509 Speed up Counter operators https://bugs.python.org/issue23502 Tkinter doesn't support large integers (out of 32-bit range) https://bugs.python.org/issue23488 Random objects twice as big as necessary on 64-bit builds https://bugs.python.org/issue23466 PEP 461: Inconsistency between str and bytes formatting of integers https://bugs.python.org/issue23419 Faster default __reduce__ for classes without __init__ https://bugs.python.org/issue23290 Faster set copying https://bugs.python.org/issue23252 Add support of writing to unseekable file (e.g. socket) in zipfile https://bugs.python.org/issue23502 pprint: added support for mapping proxy https://bugs.python.org/issue23001 Accept mutable bytes-like objects in builtins that for now support only read-only bytes-like objects https://bugs.python.org/issue22995 Restrict default pickleability. Fail earlier for some types instead of producing incorrect data. https://bugs.python.org/issue22958 Constructors of weakref mapping classes don't accept "self" and "dict" keyword arguments https://bugs.python.org/issue22831 Use "with" to avoid possible fd leaks. Large patch with many simple changes. https://bugs.python.org/issue22826 Support context management protocol in bkfile and simplify Tools/freeze/bkfile.py https://bugs.python.org/issue22721 pprint output for sets and dicts is not stable https://bugs.python.org/issue22687 horrible performance of textwrap.wrap() with a long word https://bugs.python.org/issue22682 Add support of KZ1048 (RK1048) encoding https://bugs.python.org/issue22681 Add support of KOI8-T encoding https://bugs.python.org/issue23671 string.Template doesn't work with the self keyword argument https://bugs.python.org/issue23171 Accept arbitrary iterables in cvs.writerow() https://bugs.python.org/issue23136 Fix inconsistency in handling week 0 in _strptime() https://bugs.python.org/issue22557 Speed up local import https://bugs.python.org/issue22493 Deprecate the use of flags not at the start of regular expression https://bugs.python.org/issue22390 test.regrtest should complain if a test doesn't remove temporary files https://bugs.python.org/issue22364 Improve some re error messages using regex for hints https://bugs.python.org/issue22115 Add new methods to trace Tkinter variables https://bugs.python.org/issue22035 Fatal error in dbm.gdbm https://bugs.python.org/issue21802 Reader of BufferedRWPair is not closed if writer's close() fails https://bugs.python.org/issue21859 Add Python implementation of FileIO https://bugs.python.org/issue21717 Exclusive mode for ZipFile https://bugs.python.org/issue21708 Deprecate nonstandard behavior of a dumbdbm database https://bugs.python.org/issue21526 Support new booleans in Tkinter https://bugs.python.org/issue20168 Derby: Convert the _tkinter module to use Argument Clinic https://bugs.python.org/issue20159 Derby: Convert the ElementTree module to use Argument Clinic https://bugs.python.org/issue20148 Derby: Convert the _sre module to use Argument Clinic https://bugs.python.org/issue19930 os.makedirs('dir1/dir2', 0) always fails https://bugs.python.org/issue18684 Pointers point out of array bound in _sre.c https://bugs.python.org/issue18473 Some objects pickled by Python 3.x are not unpicklable in Python 2.x https://bugs.python.org/issue17711 Persistent id in pickle with protocol version 0 https://bugs.python.org/issue17530 pprint could use line continuation for long bytes literals https://bugs.python.org/issue16314 Support xz compression in distutils https://bugs.python.org/issue15490 Correct __sizeof__ support for StringIO https://bugs.python.org/issue15133 Make tkinter.getboolean() and BooleanVar.get() support Tcl_Obj and always return bool. https://bugs.python.org/issue14904 test_unicode_repr_oflw (in test_bigmem) crashes https://bugs.python.org/issue14260 Make re.groupindex non-modifiable. https://bugs.python.org/issue13583 Add support of slice indexes in sqlite3.Row https://bugs.python.org/issue11344 Add os.path.splitpath(path) function https://bugs.python.org/issue10803 Better support of bytearray objects in ctypes https://bugs.python.org/issue6598 calling email.utils.make_msgid frequently has a non-trivial probability of generating colliding ids https://bugs.python.org/issue4727 Use pickle protocol 4 in the copy module for support more types https://bugs.python.org/issue2175 Add support of character streams of InputSource object in SAX parsers https://bugs.python.org/issue433028 Add support if local flags in regular expressions. (?flag:...)

On 19 March 2015 at 19:28, Serhiy Storchaka <storchaka@gmail.com> wrote:
Here is list of my ready for review patches. It is incomplete and contains only patches for which I don't expect objections or long discussion. Most of them are relative easy and need only formal review. Most of them wait for a review many months.
It's worth noting that If there are changes you feel are genuinely low risk, you can go ahead and merge them based on your own commit review (even if you also wrote the original patch). It's far from ideal, but also a pragmatic recognition of how low the available amount of core developer time we have is relative to the amount of work that *could* be done :( The only time that guideline doesn't apply is if the release manager declares mandatory commit reviews while preparing a release, and I think Larry uses a release branch for that these days instead. Regards, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia

On 21.03.15 13:46, Nick Coghlan wrote:
On 19 March 2015 at 19:28, Serhiy Storchaka <storchaka@gmail.com> wrote:
Here is list of my ready for review patches. It is incomplete and contains only patches for which I don't expect objections or long discussion. Most of them are relative easy and need only formal review. Most of them wait for a review many months.
It's worth noting that If there are changes you feel are genuinely low risk, you can go ahead and merge them based on your own commit review (even if you also wrote the original patch).
Yes, but four eyes are better than two eyes. I make mistakes. In some issues I hesitate about documentation part. In some issues (issue14260 and issue22721) I provided two alternative solutions and need a tip to choose from them. While I am mainly sure about the correctness of the patch, I'm often hesitate about the direction. Is the bug worth fixing? Is the new feature worth to be added to Python? Thanks Alexander, Amaury, Benjamin, Berker, Demian, Éric, Ethan, Martin, Paul, Victor and others that responded on my request.

On 22 Mar 2015 19:22, "Serhiy Storchaka" <storchaka@gmail.com> wrote:
On 21.03.15 13:46, Nick Coghlan wrote:
On 19 March 2015 at 19:28, Serhiy Storchaka <storchaka@gmail.com> wrote:
Here is list of my ready for review patches. It is incomplete and
contains
only patches for which I don't expect objections or long discussion. Most of them are relative easy and need only formal review. Most of them wait for a review many months.
It's worth noting that If there are changes you feel are genuinely low risk, you can go ahead and merge them based on your own commit review (even if you also wrote the original patch).
Yes, but four eyes are better than two eyes. I make mistakes. In some issues I hesitate about documentation part. In some issues (issue14260 and issue22721) I provided two alternative solutions and need a tip to choose from them. While I am mainly sure about the correctness of the patch, I'm often hesitate about the direction. Is the bug worth fixing? Is the new feature worth to be added to Python?
Aye, agreed - those are the kinds of cases where I'd nudge folks for a review as well. Committing directly is something I'd only do where I'm already entirely confident the change is an improvement over the status quo. However, now that I think about it further, it's very rare for me to be completely confident in a change without another core dev at least giving a +1 on the general idea.
Thanks Alexander, Amaury, Benjamin, Berker, Demian, Éric, Ethan, Martin, Paul, Victor and others that responded on my request.
Indeed! One of the things I'm actually hoping to achieve through PEPs like 474 & 462 is to get to a point where we can better acknowledge and thank folks for all the work that goes into patch reviews :) Cheers, Nick.
_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe:
https://mail.python.org/mailman/options/python-dev/ncoghlan%40gmail.com

2015-03-19 10:28 GMT+01:00 Serhiy Storchaka <storchaka@gmail.com>:
https://bugs.python.org/issue23681 Have -b warn when directly comparing ints and bytes
closed
https://bugs.python.org/issue23676 Add support of UnicodeTranslateError in standard error handlers
commented
https://bugs.python.org/issue23671 string.Template doesn't work with the self keyword argument
closed
https://bugs.python.org/issue23637 Outputting warnings fails when file patch is not ASCII and message is unicode on 2.7.
commented
https://bugs.python.org/issue23622 Deprecate unrecognized backslash+letter escapes in re
closed
https://bugs.python.org/issue23611 Pickle nested names (e.g. unbound methods) with protocols < 4
commented
https://bugs.python.org/issue23583 IDLE: printing unicode subclasses broken (again)
closed
https://bugs.python.org/issue23573 Avoid redundant memory allocations in str.find and like
closed and reopened, already commented
https://bugs.python.org/issue23509 Speed up Counter operators
reviewed
https://bugs.python.org/issue23502 Tkinter doesn't support large integers (out of 32-bit range)
closed (note: the title was different, "pprint: added support for mapping proxy")
https://bugs.python.org/issue23488 Random objects twice as big as necessary on 64-bit builds
reviewed
https://bugs.python.org/issue23466 PEP 461: Inconsistency between str and bytes formatting of integers
already reviewed
https://bugs.python.org/issue23419 Faster default __reduce__ for classes without __init__
closed (rejected)
https://bugs.python.org/issue23290 Faster set copying
commented and reviewed I stop here for tonight. Victor

On 27.03.15 02:16, Victor Stinner wrote:
2015-03-19 10:28 GMT+01:00 Serhiy Storchaka <storchaka@gmail.com>:
https://bugs.python.org/issue23502 Tkinter doesn't support large integers (out of 32-bit range)
closed (note: the title was different, "pprint: added support for mapping proxy")
My fault. The correct issue is https://bugs.python.org/issue16840.
I stop here for tonight.
Many thanks Victor!
participants (3)
-
Nick Coghlan
-
Serhiy Storchaka
-
Victor Stinner