attribution? (was: CVS: python/dist/src/Objects unicodeobject.c,2.32,2.33)
On Fri, Jun 30, 2000 at 07:58:23AM -0700, M.-A. Lemburg wrote:
Update of /cvsroot/python/python/dist/src/Objects In directory slayer.i.sourceforge.net:/tmp/cvs-serv12549/Objects
Modified Files: unicodeobject.c Log Message: Marc-Andre Lemburg <mal@lemburg.com>: A previous patch by Jack Jansen was accidently reverted.
Is placing your email address into the log message really useful? After all, the checkin is already labeled as yours. I'm all for complete log messages, but scattering emails in there is a bit redundant. Certainly, if you commit somebody *else's* patch, then put their name in. Cheers, -g -- Greg Stein, http://www.lyra.org/
Greg Stein wrote:
On Fri, Jun 30, 2000 at 07:58:23AM -0700, M.-A. Lemburg wrote:
Update of /cvsroot/python/python/dist/src/Objects In directory slayer.i.sourceforge.net:/tmp/cvs-serv12549/Objects
Modified Files: unicodeobject.c Log Message: Marc-Andre Lemburg <mal@lemburg.com>: A previous patch by Jack Jansen was accidently reverted.
Is placing your email address into the log message really useful? After all, the checkin is already labeled as yours.
I'm all for complete log messages, but scattering emails in there is a bit redundant.
Certainly, if you commit somebody *else's* patch, then put their name in.
I wasn't sure whether the person who checks in patches appears in the CVS log, so I added the name and email in front of the message. I'll remove the note in my checkin script. -- Marc-Andre Lemburg ______________________________________________________________________ Business: http://www.lemburg.com/ Python Pages: http://www.lemburg.com/python/
participants (2)
-
Greg Stein -
M.-A. Lemburg