When building out of tree there is no .git reference. If I understand the process it uses git to see what files have changed, and does further processing on those. As to workflow, that may be better, but other than the name, unknown to me. Sent from my iPhone

On 24 Aug 2018, at 19:37, Mariatta Wijaya wrote:

I don't quite understand the problem you're facing with git and make patchcheck?

Also, perhaps this is more for core-workflow instead of python-dev.

Mariatta

ᐧ

...

On Fri, Aug 24, 2018 at 3:20 AM Michael wrote: I am trying to be a 'good scout' and run "make patchcheck" more regularly. However, I generally am not successful because I build and test in separate directories.

There is access to git! just no ready reference in the build area.

So, not calling it a bug - but if someone else also experiences this, and feels capable of makeing it more flexible - you will get thanks from me, in any case!

Michael

_______________________________________________ Python-Dev mailing list Python-Dev@python.org https://mail.python.org/mailman/listinfo/python-dev Unsubscribe: https://mail.python.org/mailman/options/python-dev/mariatta.wijaya%40gmail.c...

On 28/08/2018 09:57, Stephen J. Turnbull wrote:

Michael Felt (aixtools) writes:

...

When building out of tree there is no .git reference. If I understand the process it uses git to see what files have changed, and does further processing on those.

Just guessing based on generic git knowledge here:

If you build in a sibling directory of the .git directory, git should "see" the GITDIR, and it should work. Where is your build directory relative to the GITDIR? I work in "parallel" /data/prj/python/python-version /data/prj/python/git/python-version

I suppose I should try setting GITDIR - but, I think it would be better, at least nicer, if "patchcheck" as a target did some checking for git early on, rather than bail out at the end. The results of the check might be just a message to set GITDIR, e.g..

I suspect you could also set GITDIR=/path/to/python/source/.git in make's process environment, and do "make patchcheck" outside of the Python source tree successfully. I'll give this a try next time around. (vacation, so not really 'active' atm).

Thanks for the suggestions.

Regards,